meta: require DCO signoff in commit message guidelines#62510
Conversation
|
Review requested:
|
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
I don't know about the multiple author rules, sometimes PRs get abandoned and picked up by someone else, this imply we have no choice but to not attribute the work to the original author – but if "should" means "it is recommended", I guess it's fine
|
That actually gets a bit tricky. If I start work, then abandon it, and you pick it up later... My part of the contribution is still mine and I should sign off on it. I should have signed off from the start. |
|
@nodejs/tsc |
|
Assuming we move forward with this requirement, we should pin an issue in the tracker for a bit calling it out. |
|
@nodejs/tsc ... i'm planning to leave this open for a couple more days in case there are objections / concerns. So far none have been raised. |
|
@nodejs/tsc planning to land this later today. |
Apply suggestion from @jasnell PR-URL: #62510 Refs: nodejs/core-validate-commit#141 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in c02bee3 |
Apply suggestion from @jasnell PR-URL: #62510 Refs: nodejs/core-validate-commit#141 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Apply suggestion from @jasnell PR-URL: #62510 Refs: nodejs/core-validate-commit#141 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
10 participants
Refs: nodejs/core-validate-commit#141